Skip to content

Update main cue position before seeking to it#4370

Merged
Be-ing merged 2 commits intomixxxdj:mainfrom
ywwg:cue-seek-fix
Oct 12, 2021
Merged

Update main cue position before seeking to it#4370
Be-ing merged 2 commits intomixxxdj:mainfrom
ywwg:cue-seek-fix

Conversation

@ywwg
Copy link
Copy Markdown
Member

@ywwg ywwg commented Oct 9, 2021

@Holzhaus
Copy link
Copy Markdown
Member

Holzhaus commented Oct 9, 2021

Thanks. This bug only affects CDJ mode and the cue_cdj CO?

@ywwg
Copy link
Copy Markdown
Member Author

ywwg commented Oct 9, 2021

looking through the function, I believe this is the only mode affected. None of the others updated the cue position

Copy link
Copy Markdown
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. Do you want to add a test?

@ywwg
Copy link
Copy Markdown
Member Author

ywwg commented Oct 10, 2021

oh I just found another instance of the same mistake, updating

@ninomp
Copy link
Copy Markdown
Contributor

ninomp commented Oct 12, 2021

I just tested this and it indeed solves the issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants